Major refactoring of string handling #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support interpolated strings - Multiline strings are lifted to the top-level of the program because by default the F# includes the indentation of the current scope as part of the string, this made it very difficult to format multiline strings because there were no guarantees what the actual result would end up being. We also normalize multiline strings to match C# raw-string literals on how the indentation is managed. This may not work 100% accurately but it should be an improvement and it can be improved in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support interpolated strings
Multiline strings are lifted to the top-level of the program
because by default the F# includes the indentation of the current
scope as part of the string, this made it very difficult to format
multiline strings because there were no guarantees what the
actual result would end up being.
We also normalize multiline strings to match C# raw-string literals
on how the indentation is managed. This may not work 100% accurately
but it should be an improvement and it can be improved in the future.